-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: settings dialog #4265
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/components/SettingsDialog/ShareSession/ShareSession.tsx
🐙 OctomindTest Report: 14/14 successful.
commit sha: 0e85826 |
src/components/BoardHeader/HeaderMenu/BoardOptions/BoardOptionButton.tsx
Outdated
Show resolved
Hide resolved
also actually apply it
`MenuKey` -> `MenuItemKey` `MenuItem` -> `MenuItemConfig` `MENU_ENTRY_CONFIG` -> `MENU_ITEM_CONFIG`
# Conflicts: # src/components/SettingsDialog/Participants/Participants.tsx # src/components/SettingsDialog/ProfileSettings/ProfileSettings.tsx # src/components/SettingsDialog/SettingsDialog.tsx
The deployment to the dev cluster was successful. You can find the deployment here: https://4265.development.scrumlr.fra.ics.inovex.io Deployed Images
|
Description
Refactors the settings dialog. The reason for this is the fact the settings will be required at other locations (like templates/sessions, #4254), and while the current state was great, it had some issues:
The new solution provides solutions for all of these:
/settings
, automatically redirect to the first allowed optionChangelog
constants/settings.ts
incuding nessecary types and list of all menu itemsChecklist