Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: settings dialog #4265

Merged
merged 62 commits into from
Oct 11, 2024
Merged

refactor: settings dialog #4265

merged 62 commits into from
Oct 11, 2024

Conversation

Schwehn42
Copy link
Collaborator

Description

Refactors the settings dialog. The reason for this is the fact the settings will be required at other locations (like templates/sessions, #4254), and while the current state was great, it had some issues:

  1. hardcoded menu items
  2. state that wouldn't be available on other pages (like board state)
  3. hardcoded navigation

The new solution provides solutions for all of these:

  1. dynamically render menu items
    1. all sections are kept in a configurable file
    2. each section can be enabled/disabled using props
  2. remove or outsource unnessecary state
  3. dynamic navigation
    1. returning to previous route instead of navigatin to hardcoded routes
    2. when navigating to /settings, automatically redirect to the first allowed option

Changelog

  • add file constants/settings.ts incuding nessecary types and list of all menu items
  • SettingsDialog
    • add render function
    • adjust logic
  • add tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jun 26, 2024

This comment has been minimized.

This comment has been minimized.

@Schwehn42 Schwehn42 added Review Needed This pull request is ready for review and removed Review Needed This pull request is ready for review labels Jul 19, 2024
Copy link

octomind-dev bot commented Jul 24, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 0e85826

.eslintrc.json Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
src/routes/Router.tsx Show resolved Hide resolved
src/constants/settings.ts Show resolved Hide resolved
src/constants/settings.ts Outdated Show resolved Hide resolved
src/constants/settings.ts Outdated Show resolved Hide resolved
@brandstetterm brandstetterm removed the Review Needed This pull request is ready for review label Aug 28, 2024
@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Aug 29, 2024
`MenuKey` -> `MenuItemKey`
`MenuItem` -> `MenuItemConfig`
`MENU_ENTRY_CONFIG` -> `MENU_ITEM_CONFIG`
@Schwehn42 Schwehn42 added Review Needed This pull request is ready for review and removed Changes Requested Changes requested by the reviewer labels Sep 11, 2024
@Schwehn42 Schwehn42 mentioned this pull request Sep 30, 2024
3 tasks
# Conflicts:
#	src/components/SettingsDialog/Participants/Participants.tsx
#	src/components/SettingsDialog/ProfileSettings/ProfileSettings.tsx
#	src/components/SettingsDialog/SettingsDialog.tsx
@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Oct 11, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit fccbb16 Oct 11, 2024
7 checks passed
@Schwehn42 Schwehn42 deleted the js/refactor-settings-dialog branch October 11, 2024 10:28
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4265.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-2301262

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-2301262

@Schwehn42 Schwehn42 mentioned this pull request Oct 24, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants